RFR: 8327179: Update the 3D lighting application [v3]

Nir Lisker nlisker at openjdk.org
Wed Mar 13 21:48:43 UTC 2024


On Tue, 5 Mar 2024 16:49:28 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   copyright headers
>
> tests/performance/3DLighting/src/main/java/lighting3D/Benchmark.java line 49:
> 
>> 47:         stopGraphic.setBoundsType(TextBoundsType.VISUAL);
>> 48:         stopGraphic.setFill(Color.RED);
>> 49:         stopGraphic.setFont(Font.font(20));
> 
> Play and Stop button could be same size. It would be good to look at. Currently the Stop button seems lesser than half size of play button.

As you will see, the font sizes and visual sizes don't render as you would expect. Not sure why, but this way they look better. Perhaps small adjustments are in order, but if you match the sizes it comes out off.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1387#discussion_r1523953194


More information about the openjfx-dev mailing list