RFR: 8327179: Update the 3D lighting application

Nir Lisker nlisker at openjdk.org
Wed Mar 13 22:36:42 UTC 2024


On Tue, 5 Mar 2024 16:44:00 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

> Executing the LightingSample manually fails with an exception

I think the package names of the main and resources weren't aligned.

> The copyright year new files should be 2024 only. Some new files have more than one copyright year. If you are moving any existing files then please use git mv so that the files are shown as moved.

For now, for the ease of reviewing, I reverted the package name change.

> The effect of lighting on mesh vs a box is quite different.

I think this is the same issue you submitted in the past: https://bugs.openjdk.org/browse/JDK-8269133

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1387#issuecomment-1996005413


More information about the openjfx-dev mailing list