RFR: JDK-8327727: Changing the row factory of a TableView does not recreate the rows
Andy Goryachev
angorya at openjdk.org
Wed Mar 13 23:44:41 UTC 2024
On Sat, 9 Mar 2024 19:52:25 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
> The fix is very straightfoward. We request a recreation of all cells in the `VirtualFlow` by calling `flow.recreateCells()` when the `tableRowFactory` was changed.
>
> Funny enough, this was done in the `TreeTableViewSkin` again, hence it did not suffer from this bug. Removed as the table row factory is already handled in the `TableViewSkinBase`, now with the correct recreation.
Verified with the updated Monkey Tester
https://github.com/andy-goryachev-oracle/MonkeyTest
(TableView -> Row Factory:)
on macOS 14.3.1 M1
-------------
Marked as reviewed by angorya (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1396#pullrequestreview-1935402562
More information about the openjfx-dev
mailing list