RFR: 8323511 Scrollbar Click jumps inconsistent amount of pixels [v2]

[Johan Vos]

On Mon, 11 Mar 2024 15:18:51 GMT, eduardsdv <duke at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 1556:
>> 
>>> 1554:         if (targetCell != null) {
>>> 1555:             if (targetIndex < 0) {
>>> 1556:                 T cell = getCell(targetIndex);
>> 
>> Is there a reason you call `getCell` here, but `getAvailableCell` below?
>
> As I was also involved in fixing this error, I can answer.
> 
> The `getAvailableCell()` method creates a new cell if none exists for the specified index (-1). 
> The `getCell()` returns the `accumCell` in this case, which is completely sufficient for our case, because we only need the dimensions of the cell here. The cell itself will not be added to the scene-graph.

That sounds right.
@Maran23 does this answer your question?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1326#discussion_r1527573232