RFR: 8328400: Minor Cleanup

[Marius Hanl]

On Tue, 19 Mar 2024 15:18:09 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> - PrismTextLayout:325 misspelled 'sliptCaretOffset'
> - DatePicker System.err.println L 125, 139, 172, 256
> - SpinnerTest.java L 1588, 1609 -> loses/losing (also in MenuBarSkin, DatePickerTest, FocusTest, and a few more)
> - Labeled:821 obsolete comment
> 
> Some more typos:
> - occuring -> occurring (e.g. CellBehaviourBase)
> - ButtonTest - conextMenuShouldntShowOnAction -> context...
> - ControlResources - translateable -> translatable
> - DateCellSkin - Pirvate -> Private
> - totaly -> totally (e.g. LineChart)
> - MenuItem - programatically -> programmatically
> - Tooltip - invaildated -> invalidated
> 
> (thank you @Maran23 )

The draft looks good to me so far.

modules/javafx.controls/src/main/java/javafx/scene/control/DatePicker.java line 126:

> 124:                 //System.err.println("Restoring value to " +
> 125:                 //        ((lastValidDate == null) ? "null" : getConverter().toString(lastValidDate)));
> 126:                 setValue(lastValidDate);

FYI I found it very weird that `DatePicker` tries to 'recover' itself when wrong values are set. I think this is the only? `Control` that does this behaviour

-------------

Marked as reviewed by mhanl (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1409#pullrequestreview-1948506901
PR Review Comment: https://git.openjdk.org/jfx/pull/1409#discussion_r1531848246