RFR: 8316372: Monkey Tester Application Part 3

[Kevin Rushforth]

On Mon, 18 Mar 2024 21:02:54 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Further changes to the MonkeyTester application:
> 
> - remember split pane divider ✔
> - use 'private' instead of 'protected' in many cases ✔
> - added more scripts to the 'writing systems' text sample ✔
> - added RTL window control menu ✔
> - added embedded swing/fx in tools ✔
> - added copy popup menu in clipboard viewer ✔
> - added the custom css field to the css playground tool ✔
> - added many new pages ✔
> - split XYChartPage into separate pages ✔
> - switched to use property sheets (some choices might be incomplete) ✔
> 
> https://github.com/andy-goryachev-oracle/jfx/blob/8316372.monkey/tests/manual/monkey/README.md

I added one convenience suggestion inline.

Unrelated to the suggestion, I get a compilation error. You have a problem with a mismatch in the case of one filename versus its class name.


$ ant -Djavafx.home=../../../build/sdk
Buildfile: jfx/tests/manual/monkey/build.xml
...
compile:
    [javac] Compiling 105 source files to jfx/tests/manual/monkey/build/classes
    [javac] jfx/tests/manual/monkey/src/com/oracle/tools/fx/monkey/pages/HtmlEditorPage.java:39: error: class HTMLEditorPage is public, should be declared in a file named HTMLEditorPage.java
    [javac] public class HTMLEditorPage extends TestPaneBase implements HasSkinnable {
    [javac]        ^
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 1 error

BUILD FAILED
jfx/tests/manual/monkey/build.xml:45: Compile failed; see the compiler error output for details.

Total time: 2 seconds

tests/manual/monkey/build.xml line 6:

> 4:   ant -Djavafx.home=<DIR>
> 5: -->
> 6: <project default="build-all" basedir=".">

If you add the following property as a default for `javafx.home`, then you can build it using just "ant" without having to specify it on the command line:


    <property name="javafx.home" value="../../../build/sdk" />

-------------

PR Review: https://git.openjdk.org/jfx/pull/1406#pullrequestreview-1950443223
PR Review Comment: https://git.openjdk.org/jfx/pull/1406#discussion_r1533046067