RFR: 8328667: [Testbug] Enable ignored Spinner unit tests

Kevin Rushforth kcr at openjdk.org
Thu Mar 21 12:56:27 UTC 2024


On Thu, 21 Mar 2024 07:18:28 GMT, Karthik P K <kpk at openjdk.org> wrote:

> Enabled a test in `SpinnerTest` class.
> Added comment to the editing test, why it can not be enabled. When Spinner value is set using `getEditor` `setText` method, the listener added to the spinner is not invoked. There is no bug for this issue. I'm not sure about the expectation in this case.
> Other set of tests which are ignored are `LocalTimeSpinnerValueFactory` tests. Since these tests are unstable and fail only at certain time of the day, not enabling this test as well.

modules/javafx.controls/src/test/java/test/javafx/scene/control/SpinnerTest.java line 341:

> 339:      **************************************************************************/
> 340: 
> 341:     @Ignore("Need KeyboardEventFirer. Listener not invoked on changing value using setText method")

Please file a bug for this and change the String to that bug ID, e.g., `@Ignore("JDK-nnnnnnn")`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1414#discussion_r1533852943


More information about the openjfx-dev mailing list