RFR: 8328667: [Testbug] Enable ignored Spinner unit tests [v2]

Kevin Rushforth kcr at openjdk.org
Thu Mar 21 14:54:29 UTC 2024


On Thu, 21 Mar 2024 13:40:37 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> Enabled a test in `SpinnerTest` class.
>> Added comment to the editing test, why it can not be enabled. When Spinner value is set using `getEditor` `setText` method, the listener added to the spinner is not invoked. There is no bug for this issue. I'm not sure about the expectation in this case.
>> Other set of tests which are ignored are `LocalTimeSpinnerValueFactory` tests. Since these tests are unstable and fail only at certain time of the day, not enabling this test as well.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add bug id to ignore comment

Marked as reviewed by kcr (Lead).

Looks good.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1414#pullrequestreview-1952471541
PR Comment: https://git.openjdk.org/jfx/pull/1414#issuecomment-2012513510


More information about the openjfx-dev mailing list