RFR: 8328667: [Testbug] Enable ignored Spinner unit tests [v2]

Kevin Rushforth kcr at openjdk.org
Thu Mar 21 15:07:34 UTC 2024


On Thu, 21 Mar 2024 14:58:15 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add bug id to ignore comment
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/SpinnerTest.java line 341:
> 
>> 339:      **************************************************************************/
>> 340: 
>> 341:     @Ignore("JDK-8328701")
> 
> the spinner is not editable and no commitValue() is issued (please see my comment in the ticket)
> 
> https://bugs.openjdk.org/browse/JDK-8328701?focusedId=14659352&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14659352

In that case, maybe you can repurpose that JBS bug ID into a test bug? Either way, using that bug ID to skip this test seems good.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1414#discussion_r1534100642


More information about the openjfx-dev mailing list