RFR: 8328742: Remove unused imports in manual tests

Kevin Rushforth kcr at openjdk.org
Thu Mar 21 21:14:31 UTC 2024


On Thu, 21 Mar 2024 19:38:38 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Using Eclipse IDE to remove unused imports in **manual tests** and update the copyright year to 2024. Using wildcard for more than 10 static imports.
> 
> **PROBLEM**
> The code in `graphics/build/gensrc/jsl-decora/` is generated and cannot be fixed.
> This means this warning **must be suppressed** in IDEs until the generator script is changed not to emit unused imports.
> 
> --
> 
> This is a trivial change, 1 reviewer is probably enough.

I recommend to revert the change to the swing class. Also, you have a copy/paste error in the description regarding generated source files.

modules/javafx.swing/src/main/java/javafx/embed/swing/InputMethodSupport.java line 45:

> 43: import com.sun.javafx.application.PlatformImpl;
> 44: import com.sun.javafx.collections.ObservableListWrapper;
> 45: import com.sun.javafx.scene.input.ExtendedInputMethodRequests;

Probably better to do this one separately. It seems OK to combine with another module, but I'd prefer it separate from what is otherwise a test-only change.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1418#pullrequestreview-1953259841
PR Review Comment: https://git.openjdk.org/jfx/pull/1418#discussion_r1534574442


More information about the openjfx-dev mailing list