RFR: 8267565: Support "@1x" and "@3x" high-density image naming convention
Kevin Rushforth
kcr at openjdk.org
Mon Mar 25 18:57:32 UTC 2024
On Fri, 22 Mar 2024 16:17:29 GMT, drmarmac <duke at openjdk.org> wrote:
> This PR extends the range of hi-res images that are loaded via naming convention, now including scale factors higher than `@2x`.
> Supporting these is already being [recommended](https://developer.apple.com/design/human-interface-guidelines/images#Best-practices) for some platforms.
>
> I tested this manually on Windows with "300%" UI scale factor, and verified `@2x` still works on macOS.
The title of this enhancement (and, thus, the PR) should be updated to indicate that `@4x` is also supported.
Related to this, I don't see logic for supporting `@1x`, so either we should add this support (carefully, because unlike the other resolutions, we do _not_ want to go looking for `@1x` unless the file without any `@` suffix is not found, since the vast majority of cases will have only a single image without any `@` suffix and even where the `@2x` convention is used, the base resolution image typically has no suffix), or else remove `@1x` from the title and file a separate issue to consider adding support for the `@1x` naming convention.
I would favor the latter (split out any support for `@1x` into a separate Enhancement request), meaning a possible title for _this_ JBS issue and PR might be:
Support "@3x" and greater high-density image naming convention
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1429#issuecomment-2018688462
More information about the openjfx-dev
mailing list