RFR: 8092102: Labeled: truncated property [v5]
Andy Goryachev
angorya at openjdk.org
Mon Mar 25 22:00:45 UTC 2024
> Adds **Labeled.textTruncated** property which indicates when the text is visually truncated (and the ellipsis string is inserted) in order to fit the available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> - width
> - wrapText
>
> I don't think it's worth creating a headful test (headless won't work) due to relative simplicity of the code.
>
> **Alternative**
>
> The desired functionality can be just as easily achieved on an application level, by adding a similar property to a subclass. What is the benefit of adding this functionality to the core?
>
> UPDATE 2024/03/07: turns out Labeled in a TableView (in a TreeTableView as well) lives by different rules (TableCellSkinBase:152, TreeTableCellSkin:126). The consequence of this is that the new functionality **cannot** be fully implemented with the public APIs alone.
>
> **See Also**
>
> * [JDK-8327483](https://bugs.openjdk.org/browse/JDK-8327483) TreeView: Allow for tooltip when cell text is truncated
> * [JDK-8205211](https://bugs.openjdk.org/browse/JDK-8205211) Ability to show Tooltip only when text is shown with ellipsis (...)
Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
- Merge branch 'master' into 8092102.truncated
- labeled helper
- handle tree/table view cells
- Merge remote-tracking branch 'origin/master' into 8092102.truncated
- review comments
- Merge remote-tracking branch 'origin/master' into 8092102.truncated
- 8092102 Labeled: truncated property
-------------
Changes: https://git.openjdk.org/jfx/pull/1389/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1389&range=04
Stats: 189 lines in 4 files changed: 161 ins; 19 del; 9 mod
Patch: https://git.openjdk.org/jfx/pull/1389.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1389/head:pull/1389
PR: https://git.openjdk.org/jfx/pull/1389
More information about the openjfx-dev
mailing list