RFR: JDK-8186188: TableColumHeader: initial auto-size broken if has graphic [v4]

[Marius Hanl]

On Fri, 22 Mar 2024 22:59:34 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Marius Hanl has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - JDK-8186188: copyright
>>  - JDK-8186188: fix tests
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TableColumnHeaderTreeTableTest.java line 48:
> 
>> 46: import javafx.scene.layout.HBox;
>> 47: import javafx.scene.text.Text;
>> 48: import org.junit.After;
> 
> this is a new test - should we use JUnit5?

I copied the other test class, but sure, is probably better to switch this to JUnit 5 then.

> modules/javafx.graphics/src/test/java/test/com/sun/javafx/pgstub/StubFontLoader.java line 53:
> 
>> 51:         if (name.equals("system regular")) {
>> 52:             FontHelper.setNativeFont(font, nativeFont, font.getName(), "System", "Regular");
>> 53:         } else if (name.equals("system bold")) {
> 
> does this mean this PR requires #1422 to be integrated first?

Yes, that would be easier for reviewing this. Once merged, I will update this branch. :)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1405#discussion_r1538339702
PR Review Comment: https://git.openjdk.org/jfx/pull/1405#discussion_r1538340259