RFR: 8328749: Remove unused imports in javafx.web [v2]
Kevin Rushforth
kcr at openjdk.org
Tue Mar 26 16:15:31 UTC 2024
On Tue, 26 Mar 2024 07:01:02 GMT, Hima Bindu Meda <hmeda at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> removed swing file
>
> modules/javafx.web/src/main/native/Source/WebCore/bindings/java/dom3/java/com/sun/webkit/dom/NodeImpl.java line 38:
>
>> 36: import org.w3c.dom.events.EventListener;
>> 37: import org.w3c.dom.events.EventTarget;
>> 38: import com.sun.webkit.Disposer;
>
> Minor: Generally, imports are added in alphabetic order.
I raised this question in PR #1420 as well, but didn't follow-up on it. We should make a deliberate decision on this rather than "whatever Andy's version of Eclipse happens to think is a good default". Let's resolve the discussion in _that_ PR and then apply it to all.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1421#discussion_r1539576879
More information about the openjfx-dev
mailing list