RFR: 8328746: Remove unused imports in demo apps

Kevin Rushforth kcr at openjdk.org
Tue Mar 26 17:47:26 UTC 2024


On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble, etc.) and update the copyright year to 2024. Using wildcard for more than 10 static imports.
> 
> 
> --
> 
> This is a trivial change (though fairly large), 1 reviewer is probably enough.

The other thing that a reordering of imports does is add noise to a review, so there is some advantage in having it be at least reasonably consistent. The current advice is already "try not to reorder imports", so as long as people follow that, it might be good enough. What I don't want to see is a lot of back and forth reordering, but maybe it won't be a problem (it typically hasn't been up to now).

I don't have a strong opinion on this, other than the "no wildcard imports" rule, which is separate and already documented. I do like consistency, but as long there is some reasonable ordering, I can let it go if no one else feels the need for a gudeline.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1420#issuecomment-2021091226


More information about the openjfx-dev mailing list