RFR: 8307980: Rotate Transformation never invalidates inverseCache [v2]

[Kevin Rushforth]

On Thu, 7 Mar 2024 11:47:10 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

>> Fixed as described in the issue + added tests to check for this scenario with all Transform sub classes. Since the test scenario slightly exceeding the regular parametrized testing of `TransformOperationsTest` I decided to implement the tests in a separate class.
>> 
>> I didn't manage to reproduce the issue with other Transform sub classes, so it seems to only affect `Rotate`. Also checked by looking at the code, only `Rotate` was affected by this bug. As such, without 08ba284 only `testTransformInverseCache_Rotate` fails, while others succeed. With the fix, all tests pass.
>> 
>> Ran the whole test suite afterwards and didn't notice any changes to test results after introducing the fix.
>
> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unnecessary imports from test

Looks good. I confirm that the new test fails without the fix and passes with the fix.

modules/javafx.graphics/src/test/java/test/javafx/scene/transform/TransformValidCacheAfterInverseTest.java line 116:

> 114:         checkTransform(translate);
> 115:     }
> 116: }

Minor: add (single) missing newline at the end of this file.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1392#pullrequestreview-1961384005
PR Review Comment: https://git.openjdk.org/jfx/pull/1392#discussion_r1539889095