RFR: 8273349: Check uses of Stream::peek in controls and replace as needed [v2]

[Nir Lisker]

On Wed, 27 Mar 2024 09:11:56 GMT, drmarmac <duke at openjdk.org> wrote:

>> This PR removes potentially incorrect usages of Stream.peek().
>> The changed code should be covered by the tests that are already present.
>
> drmarmac has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove outdated comment

modules/javafx.controls/src/main/java/javafx/scene/control/MultipleSelectionModelBase.java line 773:

> 771:                         .collect(Collectors.toList());
> 772: 
> 773:                 sortedNewIndices.forEach(this::set);

Why do the double-iteration pattern here and not do the `peek` operation in a `forEach` like in the other 2 places?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1430#discussion_r1541157874