RFR: 8242553: IntegerSpinner and DoubleSpinner do not wrap around values correctly in some cases

Andy Goryachev angorya at openjdk.org
Wed Mar 27 16:45:26 UTC 2024


On Sun, 24 Mar 2024 15:11:16 GMT, drmarmac <duke at openjdk.org> wrote:

> This PR should fix the issue and cover all relevant cases with new tests.
> 
> Note: This involves a small behavior change, as can be seen in dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With this change the wraparound behavior is similar to that of the IntegerSpinner.

As a user, I would be very surprised with the behavior based on modulo arithmetic.

But I do acknowledge the point made by Kevin - if this is what the application developers wanted, then it is their fault.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1431#issuecomment-2023260253


More information about the openjfx-dev mailing list