RFR: 8242553: IntegerSpinner and DoubleSpinner do not wrap around values correctly in some cases

Andy Goryachev angorya at openjdk.org
Wed Mar 27 18:33:26 UTC 2024


On Sun, 24 Mar 2024 15:11:16 GMT, drmarmac <duke at openjdk.org> wrote:

> This PR should fix the issue and cover all relevant cases with new tests.
> 
> Note: This involves a small behavior change, as can be seen in dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With this change the wraparound behavior is similar to that of the IntegerSpinner.

the end result of stepping once by `amountToStepBy` must be equivalent of incrementing by one a total of `amountToStepBy` times, wouldn't you agree?

so the formula for positive `amountToStepBy` values should look like

`((val + amountToStepBy) % (max - min)) + min`

or something along these lines.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1431#issuecomment-2023596265


More information about the openjfx-dev mailing list