RFR: 8242553: IntegerSpinner and DoubleSpinner do not wrap around values correctly in some cases

Andy Goryachev angorya at openjdk.org
Wed Mar 27 19:22:26 UTC 2024


On Wed, 27 Mar 2024 19:05:40 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> the number of discrete positions is `max - min + 1`

you are right!  my earlier comment is invalid.  please ignore.

Now, when wrapping occurs, should max/min be considered as valid steps?

Example, try both integer and double spinners with {min=0, max=10, step=7} starting with value=0.  try incrementing.

integer: 0, 7, 3, 10
double: 0, 7, 10, 0, 7, 10

And another question: should the new behavior (whatever everyone agrees to eventually) be documented?  Where?  This PR?  JBS?  Javadoc?  A markdown file in doc-files/behavior/?

Does it need a CSR?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1431#issuecomment-2023788836


More information about the openjfx-dev mailing list