RFR: 8092102: Labeled: truncated property [v6]

[Andy Goryachev]

On Wed, 27 Mar 2024 21:54:37 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Adds **Labeled.textTruncated** property which indicates when the text is visually truncated (and the ellipsis string is inserted) in order to fit the available width.
>> 
>> The new property reacts to changes in the following properties:
>> - ellipsisString
>> - font
>> - height
>> - text
>> - width
>> - wrapText
>> 
>> I don't think it's worth creating a headful test (headless won't work) due to relative simplicity of the code.
>> 
>> **Alternative**
>> 
>> The desired functionality can be just as easily achieved on an application level, by adding a similar property to a subclass.  What is the benefit of adding this functionality to the core?
>> 
>> UPDATE 2024/03/07: turns out Labeled in a TableView (in a TreeTableView as well) lives by different rules (TableCellSkinBase:152, TreeTableCellSkin:126).  The consequence of this is that the new functionality **cannot** be fully implemented with the public APIs alone.
>> 
>> **See Also**
>> 
>> * [JDK-8327483](https://bugs.openjdk.org/browse/JDK-8327483) TreeView: Allow for tooltip when cell text is truncated
>> * [JDK-8205211](https://bugs.openjdk.org/browse/JDK-8205211) Ability to show Tooltip only when text is shown with ellipsis (...)
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains ten commits:
> 
>  - test
>  - Merge remote-tracking branch 'origin/master' into 8092102.truncated
>  - Merge branch 'master' into 8092102.truncated
>  - labeled helper
>  - handle tree/table view cells
>  - Merge remote-tracking branch 'origin/master' into 8092102.truncated
>  - review comments
>  - Merge remote-tracking branch 'origin/master' into 8092102.truncated
>  - 8092102 Labeled: truncated property

modules/javafx.controls/src/test/java/test/javafx/scene/control/LabeledTruncatedTest.java line 153:

> 151: 
> 152:         // FIX fails
> 153:         //assertEquals(Boolean.TRUE, truncated.get());

still WIP, I can't figure out why the table cells have width 0

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1389#discussion_r1542092066