RFR: 8328577: Toolbar's overflow button overlaps the items

Andy Goryachev angorya at openjdk.org
Thu Mar 28 15:35:35 UTC 2024


On Thu, 28 Mar 2024 11:31:14 GMT, eduardsdv <duke at openjdk.org> wrote:

> This change fixes the calculation of which nodes go to the toolbar and which go to the overflow menu.
> It is now determined before the nodes are removed from the scene graph.
> This is important because the values returned by ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on whether the node is added to the scene graph.
> 
> Furthermore I corrected the ``hasOveflow`` value passed to the ``organizeOverflow(double, boolean)`` in ``correctOverflow(double)``.

The proposed solution still does not work - using the sample code in the ticket, try resizing back and forth around the button with -xxxx- text:

![Screenshot 2024-03-28 at 08 30 37](https://github.com/openjdk/jfx/assets/107069028/dd77173e-7197-4650-90e9-30fc7e8a9205)

a couple of notes:

1. do you think we should add a test?
2. should there be a call to applyCss() somewhere?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1434#issuecomment-2025507990
PR Comment: https://git.openjdk.org/jfx/pull/1434#issuecomment-2025510592


More information about the openjfx-dev mailing list