RFR: 8311895: CSS Transitions [v9]

Michael Strauß mstrauss at openjdk.org
Sun Mar 31 08:14:08 UTC 2024


On Tue, 14 Nov 2023 13:04:35 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test whether two Interpolatable instances are compatible
>
> modules/javafx.graphics/src/main/java/javafx/css/StyleableDoubleProperty.java line 78:
> 
>> 76: 
>> 77:         if (transition != null) {
>> 78:             timer = TransitionTimer.run(new TransitionTimerImpl(this, v), transition);
> 
> Would it be possible to check here if this timer is going to the same target?  Also see other comment about a simplification.
> 
>      if (timer == null || timer.newValue.equals(v))) {
>           timer = TransitionTimer.run(new TransitionTimerImpl(this, v), transition);
>      }

I've moved the logic to discard redundant transitions to the `StyleableProperty` implementation classes.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/870#discussion_r1545575965


More information about the openjfx-dev mailing list