RFR: 8325591: [Mac] DRAG_DONE reports null transferMode when destination is external [v4]

Lukasz Kostyra lkostyra at openjdk.org
Wed May 1 06:36:58 UTC 2024


On Tue, 30 Apr 2024 18:51:24 GMT, Martin Fox <mfox at openjdk.org> wrote:

>> At the end of a drag operation the Mac Glass code sends out a DRAG_DONE event using the operation mask tracked in the GlassDragSource to determine the final transfer mode. That mask is only updated when a window in the JavaFX app is the drop destination. If the drag moves to an external destination the mask is set to NONE. If the drag terminates in the external destination that NONE forms the basis of the transfer mode sent via the DRAG_DONE event.
>> 
>> At the very end of the drag the OS calls the NSDraggingSource (GlassDraggingSource) with the final drag operation. This PR issues the DRAG_DONE from that callback so it can get the final transfer mode correct for both internal and external destinations.
>
> Martin Fox has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update to match coding standards

LGTM

-------------

Marked as reviewed by lkostyra (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1371#pullrequestreview-2033111227


More information about the openjfx-dev mailing list