RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v25]

[Kevin Rushforth]

On Wed, 1 May 2024 04:46:29 GMT, Oliver Kopp <duke at openjdk.org> wrote:

>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>> 
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then an addition of `start` to it leads to a negative value. This is "fixed" by using `Math.max` comparing the `maxLength` and `maxLength + start`.
>
> Oliver Kopp has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adress review comments

The latest version of the fix and the test looks good to me, although I'll let @arapte and @andy-goryachev-oracle formally review it.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1442#pullrequestreview-2033525518