RFR: 8271865: SortedList::getViewIndex behaves not correctly for some index values [v3]

Kevin Rushforth kcr at openjdk.org
Thu May 2 13:47:57 UTC 2024


On Thu, 2 May 2024 13:12:09 GMT, drmarmac <duke at openjdk.org> wrote:

>> This PR adds the missing checks, as well as code documentation that an IndexOutOfBoundsException may be thrown.
>
> drmarmac has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'refs/remotes/origin/master' into fixes/transformation-list-oob
>  - use `@code` syntax
>  - JavaDoc updates
>  - TransformationList.getSourceIndex/getViewIndex should throw IOOBE
>  - Add failing test

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1432#pullrequestreview-2035791854


More information about the openjfx-dev mailing list