RFR: 8092102: Labeled: truncated property [v9]

[Kevin Rushforth]

On Thu, 2 May 2024 18:07:12 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - missing )
>>  - review comments
>>  - Merge branch 'master' into 8092102.truncated
>>  - add exports
>>  - added unit tests
>>  - Merge remote-tracking branch 'origin/master' into 8092102.truncated
>>  - test
>>  - Merge remote-tracking branch 'origin/master' into 8092102.truncated
>>  - Merge branch 'master' into 8092102.truncated
>>  - labeled helper
>>  - ... and 5 more: https://git.openjdk.org/jfx/compare/0eb4d719...aa28eb4e
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/LabeledHelper.java line 33:
> 
>> 31:  * Labeled Helper.
>> 32:  */
>> 33: public class LabeledHelper {
> 
> You might consider making `LabeledHelper` a subclass of `ControlHelper`, which is the usual pattern for helper classes of nodes, although it may not matter here (and could be done later if there was a need).

Thinking on it further, let's not do this unless / until there is a need (there likely won't be).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1389#discussion_r1588118640