RFR: 8092102: Labeled: truncated property [v9]

[Andy Goryachev]

On Thu, 2 May 2024 18:21:52 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - missing )
>>  - review comments
>>  - Merge branch 'master' into 8092102.truncated
>>  - add exports
>>  - added unit tests
>>  - Merge remote-tracking branch 'origin/master' into 8092102.truncated
>>  - test
>>  - Merge remote-tracking branch 'origin/master' into 8092102.truncated
>>  - Merge branch 'master' into 8092102.truncated
>>  - labeled helper
>>  - ... and 5 more: https://git.openjdk.org/jfx/compare/0eb4d719...aa28eb4e
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/LabeledTruncatedTest.java line 45:
> 
>> 43:  * in their skins to different code paths.
>> 44:  */
>> 45: public class LabeledTruncatedTest {
> 
> It might be worth adding a test for `Button`.

test added

> modules/javafx.controls/src/test/java/test/javafx/scene/control/LabeledTruncatedTest.java line 93:
> 
>> 91:         firePulse();
>> 92: 
>> 93:         assertFalse(control.isTextTruncated());
> 
> Can you add a test for the case where we are wrapping and the preferred height is exceeded?

test added

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1389#discussion_r1588474995
PR Review Comment: https://git.openjdk.org/jfx/pull/1389#discussion_r1588474917