RFR: 8322619: Parts of SG no longer update during rendering - overlapping - culling - dirty [v3]

[eduardsdv]

On Wed, 13 Mar 2024 09:13:20 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   reverted accidental change in the .idea folder
>
> *push*
> It's still a important bug.
> If someone can guide me on how to write tests for this, i would put in the effort.
> Maybe we could make snapshot based tests? That should work on all platforms, right?
> (Like testing whether a specific RGB value appears)
> Has something in this direction been done somewhere?

I added a test that shows that the @FlorianKirmaier's fix works. You can start it with: `gradlew -PFULL_TEST=true :systemTests:test --tests NGNodeDirtyFlagTest`.

To avoid such errors in the future, I would still suggest the refactoring, which I wrote about in my last comment.

@kevinrushforth and @arapte please review.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1310#issuecomment-2092749767