RFR: 8092102: Labeled: truncated property [v14]

Andy Goryachev angorya at openjdk.org
Mon May 6 14:53:04 UTC 2024


On Sat, 4 May 2024 14:05:19 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   whitespace
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java line 221:
> 
>> 219:         OverrunStyle type,
>> 220:         String ellipsisString,
>> 221:         AtomicBoolean textTruncated
> 
> I recommend setting `textTruncated` to false as the first statement (alternatively, add a comment that the caller is expected to initialize it to false).

setting to false would be incorrect in the case of multi-line text.

I can add a comment, though it's not a public API and there was no comment/javadoc before.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1389#discussion_r1591128736


More information about the openjfx-dev mailing list