RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v3]
eduardsdv
duke at openjdk.org
Mon May 6 17:57:00 UTC 2024
On Mon, 6 May 2024 08:49:27 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:
>> As seen in the unit test of the PR, when we click on the area above/below the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In the other cases, the assumed default cell height is used.
>>
>> With this PR, always the default cell height is used, to determine how much is scrolled.
>> This makes the behavior more consistent.
>>
>> Especially from the unit-test, it's clear that with this PR the behavior is much more consistent.
>>
>> This is also related to the following PR: https://github.com/openjdk/jfx/pull/1194
>
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>
> JDK-8323511: Fix scrolling when clicking the scrollbar track when only one cell is visible
I agree with you, at least with scrolling when clicking on the scrollbar track.
I would like to change the amount of scroll pixels to the viewport length.
PageUp/PageDown not only scrolls the view, but also moves the selection/focus, so it makes sense to align the cells up/down.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1326#issuecomment-2096601060
More information about the openjfx-dev
mailing list