RFR: 8331214: Doc: update spec for SpinnerFactory classes [v2]

Andy Goryachev angorya at openjdk.org
Mon May 6 21:50:00 UTC 2024


On Mon, 6 May 2024 21:32:07 GMT, drmarmac <duke at openjdk.org> wrote:

>> This PR updates the javadoc for the SpinnerFactory wrap-around behavior introduced in #1431.
>
> drmarmac has updated the pull request incrementally with one additional commit since the last revision:
> 
>   javaDoc updates according to code review

modules/javafx.controls/src/main/java/javafx/scene/control/SpinnerValueFactory.java line 417:

> 415:      * integer values.
> 416:      * <p>
> 417:      * If {@link #wrapAroundProperty wrapAround} is {@code true}, the {@code IntegerSpinnerValueFactory} will step from

wrapAround still does not work in Eclipse, but this does, while providing the same visuals:


{@link SpinnerValueFactory#wrapAroundProperty wrapAround}


does it work in intellij?

modules/javafx.controls/src/main/java/javafx/scene/control/SpinnerValueFactory.java line 620:

> 618:      * double values.
> 619:      * <p>
> 620:      * If {@link #wrapAroundProperty wrapAround} is {@code true}, the {@code DoubleSpinnerValueFactory} will step

same here

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1450#discussion_r1591590066
PR Review Comment: https://git.openjdk.org/jfx/pull/1450#discussion_r1591590894


More information about the openjfx-dev mailing list