RFR: 8092102: Labeled: textTruncated property [v15]

[Michael Strauß]

On Mon, 6 May 2024 15:23:20 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Adds **Labeled.textTruncated** property which indicates when the text is visually truncated (and the ellipsis string is inserted) in order to fit the available width.
>> 
>> The new property is being set by the code which computes the actual text string to be displayed (and which inserts the ellipsis string) in `LabeledSkinBase.updateDisplayedText(double,double)`.
>> 
>> 
>> **Alternative**
>> 
>> None exists as this requires changes to the core (Utils).
>> 
>> 
>> **See Also**
>> 
>> * [JDK-8327483](https://bugs.openjdk.org/browse/JDK-8327483) TreeView: Allow for tooltip when cell text is truncated
>> * [JDK-8205211](https://bugs.openjdk.org/browse/JDK-8205211) Ability to show Tooltip only when text is shown with ellipsis (...)
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   comments

modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java line 236:

> 234:         OverrunStyle type,
> 235:         String ellipsisString,
> 236:         AtomicBoolean textTruncated

Instead of returning the clipped text with the return value, and the truncation flag with an argument, have you considered just using a record to return both at the same time? That would be a cleaner solution.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1389#discussion_r1592079493