RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]
Alexander Matveev
almatvee at openjdk.org
Wed May 8 22:02:21 UTC 2024
On Wed, 8 May 2024 12:26:06 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> modules/javafx.media/src/main/native/jfxmedia/Locator/Locator.cpp line 123:
>>
>>> 121: "(Lcom/sun/media/jfxmedia/locator/ConnectionHolder;)Lcom/sun/media/jfxmedia/locator/ConnectionHolder;");
>>> 122: env->DeleteLocalRef(klass);
>>> 123: if (javaEnv.reportException() || (GetAudioStreamConnectionHolder == NULL))
>>
>> Observed a build warning (MacOS):
>>
>> warning: comparison of function 'GetAudioStreamConnectionHolder' equal to a null pointer is always false [-Wtautological-pointer-compare]
>
> Good catch. That looks like a typo to me, and should probably be `mid_GetAudioStreamConnectionHolder == null`
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1435#discussion_r1594743714
More information about the openjfx-dev
mailing list