RFR: 8323511: Scrollbar Click jumps inconsistent amount of pixels [v5]

[eduardsdv]

On Thu, 9 May 2024 14:31:56 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8323511: Mage getViewportLength() public and use it instead of getBlockIncrement()
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 1915:
> 
>> 1913: 
>> 1914:     /**
>> 1915:      * The length of the viewport portion of the VirtualFlow as computed during the layout pass.
> 
> Suggestion: use code case, `{@code VirtualFlow}`

Done.

> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 1919:
> 
>> 1917:      * but it does not necessarily have to be the same value.
>> 1918:      *
>> 1919:      * @return the viewport length in pixel
> 
> That should be "in pixels" (plural).
> 
> Also, please add an `@since 23` tag after the return tag.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1326#discussion_r1595550376
PR Review Comment: https://git.openjdk.org/jfx/pull/1326#discussion_r1595550482