RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v14]

Johan Vos jvos at openjdk.org
Thu May 9 18:07:24 UTC 2024


> A listener was added but never removed.
> This patch removes the listener when the menu it links to is cleared. Fix for https://bugs.openjdk.org/browse/JDK-8319779

Johan Vos has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:

 - Merge branch 'master' into 8319779-systemmenu
 - Remove whiteline and language error
 - Ignore test in case the underlying GlassSystemMenu is not supported.
 - Update modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/GlassSystemMenu.java
   
   Co-authored-by: John Hendrikx <john.hendrikx+github at gmail.com>
 - Merge branch 'master' into 8319779-systemmenu
 - Add additional test for IOOBE detection.
   This test comes from JDK-8323787
 - Revert some of the conditional bindings.
   Clear menu construction when an menuitem that is a menu needs to be removed
   Add a test for the latter
 - Merge remote-tracking branch 'upstream/master' into 8319779-systemmenu
 - Cleanup test
 - Add shim class so that we can access the references to com.sun.glass.ui.Menu instances.
   Add a test to make sure those references are gone.
 - ... and 5 more: https://git.openjdk.org/jfx/compare/7699c448...72029efc

-------------

Changes: https://git.openjdk.org/jfx/pull/1283/files
  Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1283&range=13
  Stats: 663 lines in 5 files changed: 462 ins; 192 del; 9 mod
  Patch: https://git.openjdk.org/jfx/pull/1283.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1283/head:pull/1283

PR: https://git.openjdk.org/jfx/pull/1283


More information about the openjfx-dev mailing list