RFR: 8279140: ComboBox can lose selected value on item change via setAll [v2]

Andy Goryachev angorya at openjdk.org
Wed May 15 15:01:19 UTC 2024


On Thu, 9 May 2024 09:38:31 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> The `ComboBox` value was not set to previously selected value in the item list change listener when `setAll` method is used to change the items. Fixed the issue by restoring the selection in this case.
>> 
>> Added a unit test to validate the fix.
>> [JDK-8279139](https://bugs.openjdk.org/browse/JDK-8279139) is also fixed with this change and added a unit test for the same.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix JDK-8279139

looks good.  thank you for adding the tests!

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1452#pullrequestreview-2058284727


More information about the openjfx-dev mailing list