RFR: 8279140: ComboBox can lose selected value on item change via setAll [v2]

Karthik P K kpk at openjdk.org
Wed May 15 16:07:05 UTC 2024


On Tue, 14 May 2024 22:27:25 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix JDK-8279139
>
> It looks like we have quite a few bugs related to different aspects of ComboBox.  This change is definitely an improvement, as it fixes the scenario described in JDK-8279140.
> 
> This PR changes parts of the code that fixed JDK-8087838.  While I don't see a regression in respect to JDK-8087838, I do see a different behavior with and without this fix in JDK-8090221, using the test app there (to be specific, with the fix in this PR, the tester in JDK-8090221 continues to display the selected item in the combo box even though the output shows `Selected Item After: null`
> 
> Do you think that JDK-8090221 scenario is a different case and should be addressed separately?

Thanks for reviewing @andy-goryachev-oracle

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1452#issuecomment-2112931888


More information about the openjfx-dev mailing list