RFR: 8332313: Update code review guidelines

[Phil Race]

On Wed, 15 May 2024 18:56:29 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> README-code-reviews.md line 10:
>> 
>>> 8: 
>>> 9: __Project Co-Lead__: Kevin Rushforth (kcr) <br>
>>> 10: __Project Co-Lead__: Johan Vos (jvos)
>> 
>> There are two sets of ids - one for OpenJFX/JBS and one for Github.  This might be confusing sometimes, should we list both?
>
> Not sure what you mean, but it doesn't seem related to this PR.

He means people reading reviews are usually on github and your github ID is kevinrusforth,
so they might be confused by "kcr" which is your openjdk id.

Since the context is identifying OpenJDK Project leads, I think the OpenJDK ID is the right and only one to include here. At most you could clarify  like (OpenJDK ID - kcr)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1602181574