RFR: 8332313: Update code review guidelines

Andy Goryachev angorya at openjdk.org
Wed May 15 20:36:07 UTC 2024


On Wed, 15 May 2024 20:03:01 GMT, Phil Race <prr at openjdk.org> wrote:

>> Not sure what you mean, but it doesn't seem related to this PR.
>
> He means people reading reviews are usually on github and your github ID is kevinrusforth,
> so they might be confused by "kcr" which is your openjdk id.
> 
> Since the context is identifying OpenJDK Project leads, I think the OpenJDK ID is the right and only one to include here. At most you could clarify  like (OpenJDK ID - kcr)

exactly my point.  when the majority of time is spent in the context of github (PR review etc) it might be confusing when one types `@jvos` and it's not found, or when within a PR there are references to both `jvos` and `johanvos`

(see the very first comment in https://github.com/openjdk/jfx/pull/1388 )

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1602212035


More information about the openjfx-dev mailing list