RFR: 8332313: Update code review guidelines

[Kevin Rushforth]

On Wed, 15 May 2024 20:23:37 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Isn't this automatic? Seems weird you could integrate without these passing.
>
>> or is it? :-)
> 
> ![image](https://github.com/openjdk/jfx/assets/37422899/8daab7cf-f050-4964-b8a6-731666422293)
> 
> Looks to me like it is...

A passing GHA test run is neither necessary nor sufficient. It is an interesting data point. A PR can be integrated with a failing run as long as we understand why it failed. It is something for a reviewer to check and ask about if they suspect it points to a real problem. I'll reword this a little bit to make it clear. I'm sort of glad that GitHub / Azure  chose today to break it. It is a great illustration of why we don't want it to be blocking.

Btw, I filed https://bugs.openjdk.org/browse/JDK-8332328 to track the GHA failure.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1602309862