RFR: 8332313: Update code review guidelines

Kevin Rushforth kcr at openjdk.org
Wed May 15 22:24:13 UTC 2024


On Wed, 15 May 2024 20:18:05 GMT, Phil Race <prr at openjdk.org> wrote:

>> This is out of scope for this PR, but it might be something to consider addressing in a follow-on enhancement.
>
> It should be made clear (somewhere, at some point) that it would be rare for a CSR to be completed and approved before starting work on the implementation because the spec. almost always evolves as the fix is developed.

Yes, that is a good point. I'll file a follow-up to do that (since this section is otherwise unmodified from the current guidelines on the Wiki).

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1602318735


More information about the openjfx-dev mailing list