RFR: 8285893: Hiding dialog and showing new one causes dialog to be frozen
Marius Hanl
mhanl at openjdk.org
Thu May 16 07:29:13 UTC 2024
On Mon, 6 May 2024 21:11:35 GMT, Martin Fox <mfox at openjdk.org> wrote:
> I'll look into the Linux failure. The core EventLoop code passes an object into the application's leaveNestedEventLoop and expects to see that object returned from the applications's matching enterNestedEventLoop call. On Mac and Windows this object is passed through to glass as an argument on the stack. On Linux this value is handled as an application global. I suspect the Linux bookkeeping isn't robust enough to handle this case but it will take a bit to nail down the details.
There is one additional change I made, which might be relevant for Linux:
https://github.com/openjdk/jfx/pull/1324/files#diff-af779aafb50953f57cab2478dd220d0322592b60e92065cf658644866572b7e7R117
Worth to check. I remember that the code there was problematic to me.
Otherwise this looks good.
https://github.com/openjdk/jfx/pull/1324 also cleans up the unused return value which is allocated in the C++/Objective-C side, but never really used on the Java side. So might be worth to do at some point, but I would agree to do the minimal changes first.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1449#issuecomment-2114266915
More information about the openjfx-dev
mailing list