RFR: 8332313: Update code review guidelines [v2]

Kevin Rushforth kcr at openjdk.org
Fri May 17 14:10:43 UTC 2024


On Wed, 15 May 2024 22:00:42 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I think it worth noting that in skara syntax that isn't two people with the reviewer role.
>> And tell people what to use if that is what they intend - eg if I have it right
>
> It's `/reviewers 2 reviewers`, so I'll add that as an example and clarify that `/reviewers 2` is 2 with at least one reviewer.

Fixed (both the example Phil asked for and the typo Nir noted)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1605061762


More information about the openjfx-dev mailing list