RFR: 8332313: Update code review guidelines [v2]

Kevin Rushforth kcr at openjdk.org
Fri May 17 14:10:44 UTC 2024


On Wed, 15 May 2024 19:38:55 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> README-code-reviews.md line 64:
>> 
>>> 62: 
>>> 63: * Make sure you understand why there was an issue to begin with, and why/how the proposed PR solves the issue
>>> 64: * Focus first on substantive comments rather than stylistic comments
>> 
>> this is not as important as the next two.
>
> Agreed. I'll move this bullet down.

fixed

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1605057721


More information about the openjfx-dev mailing list