RFR: 8324327: ColorPicker shows a white rectangle on clicking on picker
Andy Goryachev
angorya at openjdk.org
Fri May 17 17:21:05 UTC 2024
On Fri, 17 May 2024 08:07:58 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:
> `hoverSquare`'s visible property is not initialized in the `ColorPalette` constructor.
thank you for reviewing, @arapte !
effectively, yes, and that's the issue I have fixed, by explicitly setting visibility in `setFocusedSquare()` (which is called from the constructor). I think this is a better fix because it fixes the logic in this method which may be applicable in other cases. Setting `false` to a boolean property which is already `false` has very little overhead.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1458#issuecomment-2118045404
More information about the openjfx-dev
mailing list