RFR: 8313138: Scrollbar Keyboard enhancement [v7]

[Kevin Rushforth]

On Mon, 6 May 2024 23:14:11 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Adding alt-ctrl-LEFT/RIGHT/UP/DOWN (option-command-LEFT/RIGHT/UP/DOWN) key bindings to
>> 
>> - ListView
>> - TreeView
>> - TableView
>> - TreeTableView
>> 
>> to support keyboard-only horizontal and vertical scrolling.  The main reason for the change is to improve accessibility.
>> 
>> **NOTE: For controls in right-to-left orientation, the direction of horizontal scrolling is reversed.**
>> 
>> As far as I can tell, these key combinations do not interfere with editing.
>> 
>> The proposed solution can be further optimized by adding a public method to the VirtualFlow class, something like
>> 
>> 
>> public void horizontalUnitScroll(boolean right);
>> public void verticalUnitScroll(boolean down);
>> 
>> 
>> Q: Does this change require a CSR to explain the change in the controls' behavior?  We don't yet have the key bindings documented in /doc-files/behavior
>> 
>> Note:
>> Jenkins headful test passed on all mac configurations, failed on all linux configurations (master branch failed also, so it is test issue), while windows configuration is not yet available.
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   vertical scrolling tests

Looks good. I left one comment (on a comment line) that applies to all 4 controls. I'll reapprove if you make the suggested change.

modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/ListViewBehavior.java line 933:

> 931:     }
> 932: 
> 933:     // TODO not necessary with the new InputMap V2

I recommend removing this comment. There is no public "InputMap" API in JavaFX (and this would be just one of many things that might change if an when we have such a feature).

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1393#pullrequestreview-2067087621
PR Review Comment: https://git.openjdk.org/jfx/pull/1393#discussion_r1607318160