RFR: 8313138: Scrollbar Keyboard enhancement [v8]

Andy Goryachev angorya at openjdk.org
Mon May 20 23:37:22 UTC 2024


> Adding alt-ctrl-LEFT/RIGHT/UP/DOWN (option-command-LEFT/RIGHT/UP/DOWN) key bindings to
> 
> - ListView
> - TreeView
> - TableView
> - TreeTableView
> 
> to support keyboard-only horizontal and vertical scrolling.  The main reason for the change is to improve accessibility.
> 
> **NOTE: For controls in right-to-left orientation, the direction of horizontal scrolling is reversed.**
> 
> As far as I can tell, these key combinations do not interfere with editing.
> 
> The proposed solution can be further optimized by adding a public method to the VirtualFlow class, something like
> 
> 
> public void horizontalUnitScroll(boolean right);
> public void verticalUnitScroll(boolean down);
> 
> 
> Q: Does this change require a CSR to explain the change in the controls' behavior?  We don't yet have the key bindings documented in /doc-files/behavior
> 
> Note:
> Jenkins headful test passed on all mac configurations, failed on all linux configurations (master branch failed also, so it is test issue), while windows configuration is not yet available.

Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 19 additional commits since the last revision:

 - review comments
 - Merge branch 'master' into 8313138.horizontal
 - vertical scrolling tests
 - added vertical scrolling
 - Merge branch 'master' into 8313138.horizontal
 - tests
 - cleanup
 - node orientation
 - Merge remote-tracking branch 'origin/master' into 8313138.horizontal
 - table view behavior
 - ... and 9 more: https://git.openjdk.org/jfx/compare/8b19413b...5ec3c27e

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1393/files
  - new: https://git.openjdk.org/jfx/pull/1393/files/eeaa8d91..5ec3c27e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1393&range=07
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1393&range=06-07

  Stats: 54171 lines in 177 files changed: 28150 ins; 14565 del; 11456 mod
  Patch: https://git.openjdk.org/jfx/pull/1393.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1393/head:pull/1393

PR: https://git.openjdk.org/jfx/pull/1393


More information about the openjfx-dev mailing list