RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v3]

Thiago Milczarek Sayao tsayao at openjdk.org
Thu May 23 10:53:36 UTC 2024


> This fixes two bugs appointed on the JBS issue:
> 
> 1) Sometimes window was moving to the top left corner - seems to be a bug somewhere in `gdk_window_get_origin` when used before map (a X concept when the window appears). The change is to ignore the configure events (happens when location or size changes) until window is mapped. Before map java is notified in the `set_bounds` function.
> 
> This seems to happen on newer versions of linux distros.
> 
> 2) Specific to KDE, in the case of the example provided, when an MODAL window pops, it calls `set_enabled` `false` on the child (or all other windows if APPLICATION_MODAL) which causes it to update the window constraints. When maximized, the constraints where applied anyways, causing the window to still be maximized but not show as maximized. The change is to not apply constraints when not floating (meaning floating on the screen - not maximized, fullscreen or iconified).

Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - Merge branch 'refs/heads/master' into 8332222
 - Should still report location
 - Fix
 - Teste
 - Teste
 - Teste
 - Fix 8332222

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1460/files
  - new: https://git.openjdk.org/jfx/pull/1460/files/7f6221a2..bb9a90b9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1460&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1460&range=01-02

  Stats: 55624 lines in 196 files changed: 29519 ins; 14601 del; 11504 mod
  Patch: https://git.openjdk.org/jfx/pull/1460.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1460/head:pull/1460

PR: https://git.openjdk.org/jfx/pull/1460


More information about the openjfx-dev mailing list