RFR: 8322964: Optimize performance of CSS selector matching [v9]

[John Hendrikx]

On Thu, 23 May 2024 22:44:08 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Move getStyleClassNames to location it was introduced to reduce diff
>
> modules/javafx.graphics/src/main/java/javafx/css/SimpleSelector.java line 99:
> 
>> 97:     /*
>> 98:      * Copied from removed StyleClassSet to give StyleClasses a fixed index when
>> 99:      * first encountered. No longer needed once StyleClass is removed.
> 
> Is this a possible idea for the future?

Yes, once this class is moved to private API (see https://github.com/openjdk/jfx/pull/1333) then this method can be removed.  The `SimpleSelector` class is already deprecated for removal since 23.

The method is almost impossible to reach (you'd have to cast to `SimpleSelector`), but removing it as part of this PR would have required a CSR making this harder to integrate.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1316#discussion_r1613039200